Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support exporting Torch-TRT compiled Graphmodules #3262

Merged
merged 47 commits into from
Nov 14, 2024
Merged

feat: Support exporting Torch-TRT compiled Graphmodules #3262

merged 47 commits into from
Nov 14, 2024

Conversation

peri044
Copy link
Collaborator

@peri044 peri044 commented Oct 23, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

lanluo-nvidia and others added 28 commits October 5, 2024 22:34
@lanluo-nvidia
skip run_shape_analysis
458a4d1
@lanluo-nvidia
test
2f408f9
@lanluo-nvidia
test
1c5e86c
@lanluo-nvidia
test
ba487dc
@lanluo-nvidia
Merge branch 'main' into lluo/save_remove_inputs
99d2274
@lanluo-nvidia
test
2b43480
@peri044
feat: Add re-export functionality for Torch-TRT modules
17b57a6
@lanluo-nvidia
Merge branch 'main' into lluo/save_remove_inputs
b4e02e1
@lanluo-nvidia
test
3d94f8b
@peri044
feat: add support for re-exporting graph modules
cb03ca1
@lanluo-nvidia
Merge branch 'main' into lluo/save_remove_inputs
28ba6cc
@lanluo-nvidia
resolve comments
b89cbe0
@lanluo-nvidia
Merge branch 'main' into lluo/save_remove_inputs
2843d37
@lanluo-nvidia
test
3eb48d7
@peri044
chore: updates
839c72e
@lanluo-nvidia
replace dummy inference
50eb0d8
@lanluo-nvidia
test
95ed602
@lanluo-nvidia
test
120f30d
@lanluo-nvidia
add run_test_with_dynamic_shape change
424cbf7
@lanluo-nvidia
Merge branch 'main' into lluo/save_remove_inputs
2fc9cef
@lanluo-nvidia
split the PR, add dummy inference for converter test
ef54cfc
@lanluo-nvidia
test
14f5d61
@lanluo-nvidia
test
7563959
@lanluo-nvidia
test
77355f0
@lanluo-nvidia
add linear lowering meta val
13361fd
@peri044
chore: updates
fca16a5
@lanluo-nvidia
add linear_lowering change
f0a9fef
@lanluo-nvidia
test
cff64a4
@github-actions github-actions bot added the component: core Issues re: The core compiler label Oct 23, 2024
@peri044 peri044 changed the base branch from main to lluo/save_remove_inputs October 29, 2024 20:37
@peri044 peri044 removed the request for review from gs-olive October 29, 2024 20:37
@github-actions github-actions bot removed the component: lowering Issues re: The lowering / preprocessing passes label Oct 31, 2024
@github-actions github-actions bot added the component: tests Issues re: Tests label Nov 1, 2024
@github-actions github-actions bot added the component: lowering Issues re: The lowering / preprocessing passes label Nov 13, 2024
@peri044 peri044 requested a review from zewenli98 November 13, 2024 00:34
narendasan
narendasan approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me

@github-actions github-actions bot added documentation Improvements or additions to documentation component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters labels Nov 13, 2024
@peri044 peri044 changed the base branch from lluo/save_remove_inputs to main November 13, 2024 20:40
@github-actions github-actions bot removed documentation Improvements or additions to documentation component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters labels Nov 13, 2024
@peri044
Copy link
Collaborator Author

peri044 commented Nov 14, 2024

The failing tests are related to get_hash for engine cache which is handled in another PR.

@peri044 peri044 merged commit cc0d8af into main Nov 14, 2024
44 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@zewenli98 zewenli98 Awaiting requested review from zewenli98

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: core Issues re: The core compiler component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes component: runtime component: tests Issues re: Tests WIP Work is in progress, pull request should not be merged yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peri044 @narendasan @facebook-github-bot @lanluo-nvidia